Bug 531008 – Crash in gtkprintunixdialog.c

        * gtk/gtkprintunixdialog.c: Disconnect signal handlers when
        the dialog closes. Patch by Yevgen Muntyan.

svn path=/trunk/; revision=20186

diff --git a/ChangeLog b/ChangeLog
index c162154c0d2d92e1d33952f8b938b30b0f91db21..52cd7261e271d501429b43296229f74b65fb1564 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-05-27  Matthias Clasen  <mclasen@redhat.com>
+
+       Bug 531008 – Crash in gtkprintunixdialog.c
+
+       * gtk/gtkprintunixdialog.c: Disconnect signal handlers when
+       the dialog closes. Patch by Yevgen Muntyan.
+
 2008-05-27  Matthias Clasen  <mclasen@redhat.com>
 
        RH bug 248245: cups client printing from gnome applications fail

diff --git a/gtk/gtkprintunixdialog.c b/gtk/gtkprintunixdialog.c
index da1812b4e4f7a3e7bad5681dc370bbe6cea05e63..0c8d27b76a4f3267946d479672dc90de469d8cd5 100644 (file)
--- a/gtk/gtkprintunixdialog.c
+++ b/gtk/gtkprintunixdialog.c
@@ -195,6 +195,7 @@ struct GtkPrintUnixDialogPrivate
   GList *print_backends;
   
   GtkPrinter *current_printer;
+  GtkPrinter *request_details_printer;
   guint request_details_tag;
   GtkPrinterOptionSet *options;
   gulong options_changed_handler;
@@ -449,6 +450,21 @@ gtk_print_unix_dialog_destroy (GtkPrintUnixDialog *dialog)
   clear_per_printer_ui (dialog);  
 }
 
+static void
+disconnect_printer_details_request (GtkPrintUnixDialog *dialog)
+{
+  GtkPrintUnixDialogPrivate *priv = dialog->priv;
+
+  if (priv->request_details_tag)
+    {
+      g_signal_handler_disconnect (priv->request_details_printer,
+                                   priv->request_details_tag);
+      priv->request_details_tag = 0;
+      g_object_unref (priv->request_details_printer);
+      priv->request_details_printer = NULL;
+    }
+}
+
 static void
 gtk_print_unix_dialog_finalize (GObject *object)
 {
@@ -458,13 +474,8 @@ gtk_print_unix_dialog_finalize (GObject *object)
   GList *node;
 
   unschedule_idle_mark_conflicts (dialog);
+  disconnect_printer_details_request (dialog);
 
-  if (priv->request_details_tag)
-    {
-      g_source_remove (priv->request_details_tag);
-      priv->request_details_tag = 0;
-    }
-  
   if (priv->current_printer)
     {
       g_object_unref (priv->current_printer);
@@ -1358,7 +1369,7 @@ printer_details_acquired (GtkPrinter         *printer,
 {
   GtkPrintUnixDialogPrivate *priv = dialog->priv;
 
-  priv->request_details_tag = 0;
+  disconnect_printer_details_request (dialog);
   
   if (success)
     {
@@ -1385,13 +1396,9 @@ selected_printer_changed (GtkTreeSelection   *selection,
       g_free (priv->waiting_for_printer);
       priv->waiting_for_printer = NULL;
     }
-  
-  if (priv->request_details_tag)
-    {
-      g_source_remove (priv->request_details_tag);
-      priv->request_details_tag = 0;
-    }
-  
+
+  disconnect_printer_details_request (dialog);
+
   printer = NULL;
   if (gtk_tree_selection_get_selected (selection, NULL, &filter_iter))
     {
@@ -1410,8 +1417,9 @@ selected_printer_changed (GtkTreeSelection   *selection,
       priv->request_details_tag =
        g_signal_connect (printer, "details-acquired",
                          G_CALLBACK (printer_details_acquired), dialog);
+      /* take the reference */
+      priv->request_details_printer = printer;
       gtk_printer_request_details (printer);
-      g_object_unref (printer);
       return;
     }